[Feature] cgroupv2fix: enable by default and move to nodestart #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rancherio-gh-m
pushed a commit
that referenced
this pull request
May 12, 2021
Author: Thorsten Klein <[email protected]> Date: Wed May 12 10:19:15 2021 +0200 [Feature] cgroupv2fix: enable by default and move to nodestart (#603)
|
Why is this the default? Isn't this fixed in k3s upstream with k3s-io/k3s#4086? Reason: to get NFS to work with k3d we have to use both a custom k3s image as well as a custom entrypoint (#1109 (comment)). The custom entrypoint cannot be applied because |
|
@jlian , the reason is in the comment of the issue you linked: k3s-io/k3s#4086 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the custom not-so-experimental-anymore entrypoint script for servers/agents if k3d detects that the runtime is on CgroupsV2.
This can be disabled by setting the environment variable
K3D_FIX_CGROUPV2=false.Additionally, the fix is now active also for
k3d node create, not only fork3d cluster create.Fixes #599