[Fix] Allow absolute paths for volumes on Windows (#510, @markrexwinkel) #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick and simple fix, thank you @markrexwinkel ! |
iwilltry42
changed the title
rancherio-gh-m
pushed a commit
that referenced
this pull request
Mar 2, 2021
Author: markrexwinkel <[email protected]> Date: Tue Mar 2 18:30:03 2021 +0100 [Fix] Allow absolute paths for volumes on Windows (#510, @markrexwinkel)
|
Upon creating a windows folder mapped to :shared volume it creates an error due to failed cluster configuration validation. I hope this can be fixed |
rancherio-gh-m
pushed a commit
that referenced
this pull request
Mar 29, 2021
Author: iwilltry42 <[email protected]> Date: Mon Mar 29 17:25:01 2021 +0200 [Fix] Allow absolute paths for volumes on Windows (#510, @markrexwinkel) re-applied in the pkg/util
|
@markrexwinkel replicated your fix in the correct file and removed the unused file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes the volume mount validation on Windows addressed in issue: #460.
Why
Fixes issue #460
Implications