-
-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Improved listings for nodes & registries (#439, @inercia) #439
[Enhancement] Improved listings for nodes & registries (#439, @inercia) #439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this 👍
I just left some small comments.
af08221
to
299f9a2
Compare
@iwilltry42 I have updated the PR with a more generic solution that serves to both the nodes and registries listings. |
* Function for listing nodes in a flexible way, used by the registries and nodes listing commands. * Output flags for dumping these listings as YAML/JSON. Signed-off-by: Alvaro Saurin <[email protected]>
299f9a2
to
1d5c1e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the more generic approach, good job :)
I just left one more suggestion (and a copy-paste-fix) 👍
Co-authored-by: Thorsten Klein <[email protected]>
Co-authored-by: Thorsten Klein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you! :)
--output=json/yaml
for printing theses listings as YAML/JSON.