Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improved listings for nodes & registries (#439, @inercia) #439

Merged
merged 3 commits into from
Jan 14, 2021

Conversation

inercia
Copy link
Collaborator

@inercia inercia commented Jan 9, 2021

  • Function for listing nodes in a flexible way, used by the registries and nodes listing commands.
  • New --output=json/yaml for printing theses listings as YAML/JSON.

Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this 👍
I just left some small comments.

cmd/registry/registryList.go Outdated Show resolved Hide resolved
cmd/registry/registryList.go Outdated Show resolved Hide resolved
cmd/registry/registryList.go Outdated Show resolved Hide resolved
@inercia inercia force-pushed the inercia/registries-output-format branch from af08221 to 299f9a2 Compare January 12, 2021 11:43
@inercia inercia changed the title Format option for listing registries as YAML/JSON Improved listings for nodes Jan 12, 2021
@inercia inercia requested a review from iwilltry42 January 12, 2021 11:45
@inercia
Copy link
Collaborator Author

inercia commented Jan 12, 2021

@iwilltry42 I have updated the PR with a more generic solution that serves to both the nodes and registries listings.

* Function for listing nodes in a flexible way, used by the
registries and nodes listing commands.
* Output flags for dumping these listings as YAML/JSON.

Signed-off-by: Alvaro Saurin <[email protected]>
@inercia inercia force-pushed the inercia/registries-output-format branch from 299f9a2 to 1d5c1e3 Compare January 12, 2021 16:03
Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the more generic approach, good job :)
I just left one more suggestion (and a copy-paste-fix) 👍

cmd/node/nodeList.go Outdated Show resolved Hide resolved
cmd/registry/registryList.go Outdated Show resolved Hide resolved
@iwilltry42 iwilltry42 self-assigned this Jan 14, 2021
@iwilltry42 iwilltry42 added the enhancement New feature or request label Jan 14, 2021
@iwilltry42 iwilltry42 added this to the v4.0.0 milestone Jan 14, 2021
@iwilltry42 iwilltry42 changed the title Improved listings for nodes [Enhancement] Improved listings for nodes Jan 14, 2021
Co-authored-by: Thorsten Klein <[email protected]>
cmd/registry/registryList.go Outdated Show resolved Hide resolved
cmd/registry/registryList.go Outdated Show resolved Hide resolved
cmd/registry/registryList.go Outdated Show resolved Hide resolved
Co-authored-by: Thorsten Klein <[email protected]>
@inercia inercia requested a review from iwilltry42 January 14, 2021 11:49
Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! :)

@iwilltry42 iwilltry42 changed the title [Enhancement] Improved listings for nodes [Enhancement] Improved listings for nodes & registries (#439, @inercia) Jan 14, 2021
@iwilltry42 iwilltry42 merged commit c6df144 into k3d-io:main-v4 Jan 14, 2021
@inercia inercia deleted the inercia/registries-output-format branch January 14, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants