[Feature] Choose random API Port by default #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this makes it easier to create multiple clusters without having to worry about choosing a different port every time - This is for you @ibuildthecloud ;)
... instead of leaving this up to docker, since then we don't know about it when creating the labels, etc. used e.g. for updating the kubeconfig with the correct port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no
--api-portwas specified or it's set torandom, we will now try to get a random free port from the OS/Kernel and use that one. If this fails, we'll fallback to the default (6443), just to at least have a chance.Benefits:
k3d create cluster one && k3d create cluster twoworks without having to worry about choosing free ports to avoid port collisions.