Check length of container array to prevent panic #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a cluster that died after starting due to a bad config. I quickly went to get the kubeconfig and would get a panic with an out of bounds error. An alternate would be to look at all containers and not just running.
|
when it fails you get: I could break it out into it's own check, but its kind of the same error... |
|
Closing in favor of #22 The |
|
Oh, I missed that, thank you :) |
iwilltry42
added a commit
that referenced
this pull request
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a cluster that died after starting due to a bad config. I
quickly went to get the kubeconfig and would get a panic with an
out of bounds error.
An alternate would be to look at all containers and not just running.