Makefile cleanup #20
Merged
Makefile cleanup #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra-clean target removes the dependent packages that k3d requires. This makes testing makefile rules that install those packages easier. This target helps to expose a bug that the next patch fixes.
ith a fresh checked out k3d tree without required tools installed, Any make command gives the following error message:
Makefile:71: *** recipe commences before first target. Stop.
Basically, the section around line 71 are not properly formed makefile rules. This error is hidden when required tools
are installed. The error can be re-exposed with the "make extra-clean" command.
The install-tools target is intended to be invoked when installing the development tree for the fist time.
|
LGTM, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set should improve the user experience of first time building. When running "make build" from a freshly cloned repo, I got the following error:
Makefile:71: *** recipe commences before first target. Stop.
The patch set improve the makefile by introduce the install-tools target.