Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not using stdout directly for logging #1339

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Not using stdout directly for logging #1339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/runtimes/docker/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import (
"context"
"fmt"
"io"
"os"

"github.com/docker/docker/api/types"
"github.com/docker/docker/api/types/container"
Expand Down Expand Up @@ -117,7 +116,7 @@ func pullImage(ctx context.Context, docker client.APIClient, image string) error
// in debug mode (--verbose flag set), output pull progress
var writer io.Writer = io.Discard
if l.Log().GetLevel() == logrus.DebugLevel {
writer = os.Stdout
writer = l.Log().Out
}
_, err = io.Copy(writer, resp)
if err != nil {
Expand Down