change: allow full K3s registry configuration #1215
Conversation
|
Hi @maxsargentdev thank you for this PR! |
|
Sure I will give it a go after work today :) |
|
Hey @maxsargentdev did you have any luck yet? :) |
|
Sorry haven't had time yet @iwilltry42. Feel free to take it off my hands, I will find some other area to contribute in future. |
|
@iwilltry42 is this still needing doing? Got some free time this week. |
|
@maxsargentdev yes please that would be great! I played with integrating it via wharfie, but didn't actually get around 5o properly implementing it... |
|
Roger that will take a look over the next week. |
maxsargentdev
force-pushed
the
support-registry-rewrites
branch
from
59af952 to
2c84538
Compare
|
So I have dropped the pkg/types/k3s/registry.go containing the registry types and replaced it with a wharfie import. I have updated other references and unit tests are passing, which I would expect as not much has really changed. Is this the change you had in mind? I have left my original change to pkg/client/registry.go to allow for rewrites. |
maxsargentdev
force-pushed
the
support-registry-rewrites
branch
from
ee248e1 to
8ae1353
Compare
… of config - This will allow for passing through mirror config via the config block - This wont allow rewrites to be configured as part of a k3d config file, only via registries.yaml (inline or not)
- Updated vendor folder with new deps pulled in by wharfie - Replaces old registry implementation with the exact same but from ranchers wharfie project
iwilltry42
force-pushed
the
support-registry-rewrites
branch
from
8ae1353 to
f742937
Compare
|
@maxsargentdev yep, that's it! |
iwilltry42
changed the title
What
Allow rewrites configuration via config file or inline file to be reflected in generated registries.yaml file via merge.
Why
Provide rewrite functionality from k3s private registries
Implications
No impact for previous versions.