Enable --all flag of get-kubeconfig #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwilltry42
reviewed
Oct 10, 2019
There was a problem hiding this comment.
The code looks good to me and is an easy solution 👍
However, we maybe should output the paths concatenated with a :, so you could use export KUBECONFIG="$(bin/k3d get-kubeconfig --all)" and directly have both kubeconfigs configured to switch between their contexts.
What do you think?
EDIT: nevermind, I forgot that it won't work anyway, since contexts are all called the same. We can work on this in the scope of #90 👍
iwilltry42
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the
--allflag to get the kubeconfig path from all clusters.Fix: #120