Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate checksum for k3d binaries #1209

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

kameshsampath
Copy link
Contributor

@kameshsampath kameshsampath commented Feb 3, 2023

What

Generate the release sha256 checksum file for k3d binaries

Why

#1208 , helping to verify the binaries

@all-contributors please add @kameshsampath for code

Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwilltry42
Copy link
Member

@kameshsampath thank you for this contribution! 🙏

@iwilltry42
Copy link
Member

@all-contributors please add @kameshsampath for code

@allcontributors
Copy link
Contributor

@iwilltry42

I've put up a pull request to add @kameshsampath! 🎉

@iwilltry42 iwilltry42 merged commit 44fa237 into k3d-io:main Feb 7, 2023
@dgershman
Copy link
Contributor

Did something change on this? I'm not seeing the checksums in the latest release 5.4.9.

@iwilltry42
Copy link
Member

@dgershman yeah, it never made it into the release action. I changed that now 👍

@dgershman
Copy link
Contributor

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants