Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default config template for v1alpha4 #1091

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Fix default config template for v1alpha4 #1091

merged 1 commit into from
Jun 23, 2022

Conversation

Regrau
Copy link
Contributor

@Regrau Regrau commented Jun 23, 2022

Hello everyone, the command k3d config init creates a faulty config for cluster creation. This commit moves the name into metadata.name for the k3d.io/v1alpha4 Simple format as per #945.

@iwilltry42 iwilltry42 self-requested a review June 23, 2022 15:47
@iwilltry42
Copy link
Member

Yes, thank you very much for this fix! 👍

@iwilltry42 iwilltry42 added this to the v5.5.0 milestone Jun 23, 2022
@iwilltry42 iwilltry42 added the bug Something isn't working label Jun 23, 2022
@iwilltry42 iwilltry42 merged commit 1bc5a71 into k3d-io:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwilltry42 iwilltry42 iwilltry42 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v5.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Regrau @iwilltry42