feat: allow set image in simpleConfig.Registries.Create #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaneur2020
changed the title
flaneur2020
force-pushed
the
feat-allow-image-on-create-registries
branch
2 times, most recently
from
3998bdc to
0943cab
Compare
flaneur2020
force-pushed
the
feat-allow-image-on-create-registries
branch
from
0943cab to
412950b
Compare
|
Hi @flaneur2020 , thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
this PR adds a Image config to simpleConfig.Registry.Create, so we can specify a alternative registry other than "docker.io/library/registry:2"
Why
we're running k3d in our CI infrastructure, but unfortunately runs into an error on rate limitted by docker.io registry:
we can specify a custom
--imagein thek3d registry createsubcommand which allowing us switch a private registry to avoid this problem, but we do not have a related image config in theconfig.yamlink3d cluster createyet, in our CI config, this config.yaml plays an all-in-one config for k3d, it'd be convenient to allow us config the registry image in this config file.Implications
this PR do not change the existed behavior, if the image field is empty, it falls back to the default registry image.