fail on hostaliases in hostnetwork mode

k3d-io · Jan 27, 2022 · d558787 · d558787
1 parent d0638de
commit d558787
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/cmd/cluster/clusterCreate.go b/cmd/cluster/clusterCreate.go
@@ -601,7 +601,6 @@ func applyCLIOverrides(cfg conf.SimpleConfig) (conf.SimpleConfig, error) {
 
 	// --host-alias
 	hostAliasFlags := ppViper.GetStringSlice("hostaliases")
-	l.Log().Debugf("HostAliasFlags: %+v", hostAliasFlags)
 	if len(hostAliasFlags) > 0 {
 		for _, ha := range hostAliasFlags {
 
@@ -631,7 +630,6 @@ func applyCLIOverrides(cfg conf.SimpleConfig) (conf.SimpleConfig, error) {
 			})
 		}
 	}
-	l.Log().Debugf("HostAliases: %+v", cfg.HostAliases)
 
 	return cfg, nil
 }
diff --git a/pkg/config/validate.go b/pkg/config/validate.go
@@ -76,6 +76,11 @@ func ValidateClusterConfig(ctx context.Context, runtime runtimes.Runtime, config
 		}
 	}
 
+	// hostAliases not allowed in hostnetwork mode
+	if len(config.ClusterCreateOpts.HostAliases) > 0 && config.Cluster.Network.Name == "host" {
+		return fmt.Errorf("hostAliases not allowed in hostnetwork mode")
+	}
+
 	// validate nodes one by one
 	for _, node := range config.Cluster.Nodes {