Skip to content

Commit

Permalink
Merge pull request #76 from andyz-dev/no-timeout
Browse files Browse the repository at this point in the history
[Enhancement] Deprecate --timeout, shift short hand options around
  • Loading branch information
iwilltry42 authored Jun 7, 2019
2 parents 8a59078 + f037e1b commit 5ebe276
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
4 changes: 0 additions & 4 deletions cli/commands.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,6 @@ func CreateCluster(c *cli.Context) error {
return err
}

if c.IsSet("timeout") {
log.Println("[Warning] The --timeout flag is deprecated. use '--wait <timeout>' instead")
}

// Wait for k3s to be up and running if wanted.
// We're simply scanning the container logs for a line that tells us that everything's up and running
// TODO: also wait for worker nodes
Expand Down
9 changes: 2 additions & 7 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,12 +103,7 @@ func main() {
Usage: "Specify the Kubernetes cluster API server port (Format: `[host:]port` (Note: --port/-p will be used for arbitrary port mapping as of v2.0.0, use --api-port/-a instead for setting the api port)",
},
cli.IntFlag{
Name: "timeout, t",
Value: 0,
Usage: "Set the timeout value when --wait flag is set (deprecated, use --wait <timeout> instead)",
},
cli.IntFlag{
Name: "wait, w",
Name: "wait, t",
Value: 0, // timeout
Usage: "Wait for the cluster to come up before returning until timoout (in seconds). Use --wait 0 to wait forever",
},
Expand All @@ -126,7 +121,7 @@ func main() {
Usage: "Pass an additional environment variable (new flag per variable)",
},
cli.IntFlag{
Name: "workers",
Name: "workers, w",
Value: 0,
Usage: "Specify how many worker nodes you want to spawn",
},
Expand Down

0 comments on commit 5ebe276

Please sign in to comment.