-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add streaming modified beam search #142
Add streaming modified beam search #142
Conversation
@csukuangfj I need to test the branch (and add stuff to the CI job) |
@ezerhouni Would you mind also picking up the following PR? The core part is almost finished. |
Could you also add modified_beam_search to It can be added in a separate PR. |
@csukuangfj Added streaming modified beam search to conv_emformer. I will have a look for the other PR tomorrow. If I didn't push anything, feel free to ping me. |
Thanks a lot! Could you also update the CI by changing the following lines? You only need to add "modified_beam_search" to the list.
|
@csukuangfj Yup, first I will debug the code locally and then update the CI :) |
@csukuangfj When testing on CPU I am getting : do you know if modified beam search needs to be on GPU ? |
How did you install your PyTorch? |
@csukuangfj Never mind, wrong move on my side ! |
@csukuangfj I tested the code for streaming_transducer but not for the conv_emformer. Somehow I get the following error when using the models from : https://huggingface.co/Zengwei/icefall-asr-librispeech-conv-emformer-transducer-stateless2-2022-07-05
|
What is the command you are using for testing? |
|
What is the output of
Just want to make sure that you have downloaded the pretrained model using Also, are you using PyTorch >= 1.10.0 ? |
Yes I have torch 1.12 |
The filesize of the model is only 134 bytes, which is too small. I think you don't use
You need to use |
@csukuangfj Yup working, tested and fix the issue, everything should be good to go |
@ezerhouni |
This PR adds the following :