-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding warm up for Zipformer2 #766
Conversation
- use '--warmp-up=<#warmup> for running warm ups for zipformer model' - Only supports Zipformer2 Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
c449f00
to
b4b7f58
Compare
Could you fix the build errors reported by the CI? |
For instance, see the following error from
|
- fixing minor c++ bugs - handling corner conditions - handling python csrc Signed-off-by: [email protected] <[email protected]>
- cpplint
Signed-off-by: [email protected] <[email protected]>
additional review : @pavankumar-ds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Left some minor comments.
Co-authored-by: Fangjun Kuang <[email protected]>
Signed-off-by: [email protected] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Thank you 😄 |
Hi @csukuangfj ,
How and Where to use?
use '--warmp-up=<#warmup> for running warm ups for zipformer model'
- Only supports Zipformer2 for now
- Based on requirement it can be extended
Why this is required?
Data points :
online-websocket-server.cc:main:79 Started!
online-websocket-server.cc:main:80 Listening on: 6007
online-websocket-server.cc:main:81 Number of work threads: 8
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.457923ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.170431ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.167805ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.168272ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.173339ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.169113ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.167528ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.169950ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.175659ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.524530ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.190443ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.188810ms
online-websocket-server-impl.cc:Run:250 Warm up completd : 3 times.
online-websocket-server.cc:main:79 Started!
online-websocket-server.cc:main:80 Listening on: 6007
online-websocket-server.cc:main:81 Number of work threads: 8
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.193825ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.169870ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.169398ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.172992ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.172658ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.173597ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.173040ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.171519ms
online-zipformer2-transducer-model.cc:RunEncoder:444 Encoder Duration : 0.172292ms
Let me know if additional change are required.
Thank you!