Fix a bug in mean calculation of 'ys_probs' #748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A vector variable
best_hyp.ys_probs
contains the probabilities of each token in a matched keyword whose length islevel
.The code checks if the mean of
best_hyp.ys_probs
is greater than or equal to a threshold.Problem
Currently, when calculating the mean, the index ranges from 1 to
level
.This excludes the first token (at index 0) and includes an undefined value at the end.
In most cases, this undefined value is zero so the code seems to work fine.
Solution
Change the index to range from 0 to
level
-1.