Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DirectML for windows #154

Closed
wants to merge 4 commits into from
Closed

Conversation

csukuangfj
Copy link
Collaborator

Note: It does not seem to improve the speed when passing --provider=directml from the commandline.

@thewh1teagle
Copy link
Contributor

Note: It does not seem to improve the speed when passing --provider=directml from the commandline.

What's something heavy I can test this on? I wanted to test on whisper medium but this branch does not have it.
Can I use sherpa-onnx.exe binary to test something?

@csukuangfj
Copy link
Collaborator Author

I think we should resolve the conflict and merge this PR.

If I recall correctly, it has not been merged because it does not run faster with DirectlML.

@thewh1teagle
Copy link
Contributor

thewh1teagle commented Jul 15, 2024

it has not been merged because it does not run faster with DirectlML.

I would like to check it and compare
Do I need to link onnxruntime.lib when using directml / cuda etc? it doesn't find it

@thewh1teagle
Copy link
Contributor

thewh1teagle commented Jul 15, 2024

If I recall correctly, it has not been merged because it does not run faster with DirectlML.

I tried on another c++ project that uses DirectML. it used 95% from the TPU (amd ryzen 5 4500u)
But it wasn't fast. Maybe it does works slow.
The fastest way to use whisper I found is CTranslate2 and even on CPU only!
Do you have idea how can we get similar results with sherpa?

I mean, Nvidia already should work fast, CoreML works fast. the only missing part is wide support for Windows users with AMD / Intel hardware.
I thought that DirectML is the answer, maybe with onnxruntime it will be.

@thewh1teagle
Copy link
Contributor

Any chance you could resolve the conflicts so I can test it with Whisper medium?

@csukuangfj
Copy link
Collaborator Author

Closing via #1153

@csukuangfj csukuangfj closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants