Use high_freq -400 in computing fbank features. (#515)

Fixes #514
k2-fsa · Jan 4, 2024 · 0be71a3 · 0be71a3
1 parent 547a22f
commit 0be71a3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/sherpa-onnx/csrc/features.cc b/sherpa-onnx/csrc/features.cc
@@ -46,6 +46,12 @@ class FeatureExtractor::Impl {
 
     opts_.mel_opts.num_bins = config.feature_dim;
 
+    // Please see
+    // https://github.com/lhotse-speech/lhotse/blob/master/lhotse/features/fbank.py#L27
+    // and
+    // https://github.com/k2-fsa/sherpa-onnx/issues/514
+    opts_.mel_opts.high_freq = -400;
+
     fbank_ = std::make_unique<knf::OnlineFbank>(opts_);
   }
 

diff --git a/sherpa-onnx/csrc/offline-stream.cc b/sherpa-onnx/csrc/offline-stream.cc
@@ -83,6 +83,12 @@ class OfflineStream::Impl {
     opts_.frame_opts.samp_freq = config.sampling_rate;
     opts_.mel_opts.num_bins = config.feature_dim;
 
+    // Please see
+    // https://github.com/lhotse-speech/lhotse/blob/master/lhotse/features/fbank.py#L27
+    // and
+    // https://github.com/k2-fsa/sherpa-onnx/issues/514
+    opts_.mel_opts.high_freq = -400;
+
     fbank_ = std::make_unique<knf::OnlineFbank>(opts_);
   }