Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #1157 (comment)
torch.logaddexp()
works for bothtorch.jit.script()
andtorch.jit.trace()
. However, it causes the following errors fortorch.onnx.export()
icefall/egs/librispeech/ASR/zipformer/scaling.py
Lines 29 to 31 in 98d8946
This PR makes it possible to use
torch.logaddexp()
fortorch.jit.script()
andtorch.jit.trace()
but use analternative for
torch.onnx.export()
.The following code
throws the following error for
torch.jit.script()
. That is why we puttorch.jit.is_scripting()
as the firstif
statement in this pull-request.