Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate builtin functions to package #185

Merged
merged 2 commits into from
Oct 1, 2022

Conversation

k2tzumi
Copy link
Collaborator

@k2tzumi k2tzumi commented Oct 1, 2022

T/O

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2022

Code Metrics Report

main (dd53be5) #185 (06c55ec) +/-
Coverage 78.1% 78.1% +0.0%
Code to Test Ratio 1:0.8 1:0.8 +0.0
Details
  |                    | main (dd53be5) | #185 (06c55ec) |  +/-  |
  |--------------------|----------------|----------------|-------|
+ | Coverage           |          78.1% |          78.1% | +0.0% |
  |   Files            |             22 |             24 |    +2 |
  |   Lines            |           2707 |           2707 |     0 |
+ |   Covered          |           2114 |           2115 |    +1 |
+ | Code to Test Ratio |          1:0.8 |          1:0.8 |  +0.0 |
  |   Code             |           5222 |           5232 |   +10 |
+ |   Test             |           3970 |           4038 |   +68 |

Code coverage of files in pull request scope (71.1% → 71.4%)

Files Coverage +/-
builtin/compare.go 77.8% +77.8%
builtin/time.go 100.0% +100.0%
option.go 70.7% -0.4%

Reported by octocov

@k2tzumi k2tzumi requested a review from k1LoW October 1, 2022 05:14
Comment on lines +467 to +468
Func("time", builtin.Time),
Func("compare", builtin.Compare),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to automatically expand the public functions of the buildin package.

@k2tzumi k2tzumi merged commit e6b7faa into main Oct 1, 2022
@k2tzumi k2tzumi deleted the migrate-builtin-functions-to-package branch October 1, 2022 06:41
@github-actions github-actions bot mentioned this pull request Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant