Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support current variable #119

Merged
merged 5 commits into from
Aug 28, 2022
Merged

Support current variable #119

merged 5 commits into from
Aug 28, 2022

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Aug 27, 2022

Fix #113

@k1LoW k1LoW self-assigned this Aug 27, 2022
@k1LoW k1LoW requested a review from k2tzumi August 27, 2022 22:36
@k1LoW k1LoW added the enhancement New feature or request label Aug 27, 2022
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Code Metrics Report

main (2e19b14) #119 (dbc3ce6) +/-
Coverage 73.4% 73.5% +0.0%
Code to Test Ratio 1:0.7 1:0.7 -0.0
Test Execution Time 42s 49s +7s
Details
  |                     | main (2e19b14) | #119 (dbc3ce6) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          73.4% |          73.5% | +0.0% |
  |   Files             |             18 |             18 |     0 |
  |   Lines             |           1972 |           1989 |   +17 |
+ |   Covered           |           1448 |           1461 |   +13 |
- | Code to Test Ratio  |          1:0.7 |          1:0.7 |  -0.0 |
  |   Code              |           3805 |           3836 |   +31 |
  |   Test              |           2756 |           2756 |     0 |
- | Test Execution Time |            42s |            49s |   +7s |

Code coverage of files in pull request scope (76.9% → 76.9%)

Files Coverage +/-
operator.go 74.3% +0.0%
store.go 87.5% -8.7%
test.go 94.5% +0.2%

Reported by octocov

Copy link
Collaborator

@k2tzumi k2tzumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!
LGTM!

Comment on lines +29 to +31
if runned {
store[storeCurrentKey] = rnr.operator.store.latest()
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, indeed, that’s right

So you are enabling the current variable only after execution?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think this was the only point in time to use a current variable.

@k1LoW k1LoW merged commit 41d08d6 into main Aug 28, 2022
@k1LoW k1LoW deleted the current branch August 28, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure a means of accessing the current step variable
2 participants