-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support current
variable
#119
Conversation
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Details | | main (2e19b14) | #119 (dbc3ce6) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 73.4% | 73.5% | +0.0% |
| Files | 18 | 18 | 0 |
| Lines | 1972 | 1989 | +17 |
+ | Covered | 1448 | 1461 | +13 |
- | Code to Test Ratio | 1:0.7 | 1:0.7 | -0.0 |
| Code | 3805 | 3836 | +31 |
| Test | 2756 | 2756 | 0 |
- | Test Execution Time | 42s | 49s | +7s | Code coverage of files in pull request scope (76.9% → 76.9%)
Reported by octocov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
LGTM!
if runned { | ||
store[storeCurrentKey] = rnr.operator.store.latest() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, indeed, that’s right
So you are enabling the current variable only after execution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I think this was the only point in time to use a current variable.
Fix #113