Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/min max amounts #12

Merged
merged 4 commits into from
Mar 26, 2020
Merged

Feature/min max amounts #12

merged 4 commits into from
Mar 26, 2020

Conversation

k0t3n
Copy link
Owner

@k0t3n k0t3n commented Mar 26, 2020 •
edited
Loading

k0t3n added 4 commits March 26, 2020 10:59
Changes:
547d31f 
* Some refactoring
* Handle invalid min/max amount error
* Handle unknown errors during request
Changes:
d300b82 
* Replace fixtures to conftest.py
* Cover `get_fix_rate_for_amount()` method with tests
* Update requirements.txt
Fix tests strategy
e6fd8ad
Merge branch 'master' into feature/min-max-amounts
2e57943 
# Conflicts:
#	tests/requirements.txt
@codecov
Copy link

codecov bot commented Mar 26, 2020 •
edited
Loading

Codecov Report

Merging #12 into master will increase coverage by 21.00%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #12       +/-   ##
===========================================
+ Coverage   47.61%   68.62%   +21.00%     
===========================================
  Files           3        4        +1     
  Lines          84      102       +18     
===========================================
+ Hits           40       70       +30     
+ Misses         44       32       -12
Impacted Files Coverage Δ
changelly_api/api.py 60.00% <86.66%> (+21.97%) ⬆️
changelly_api/conf.py 100.00% <100.00%> (ø)
changelly_api/exceptions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72a869c...2e57943. Read the comment docs.

@k0t3n k0t3n merged commit 72583a4 into master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@k0t3n