Allow sudofn injection into container #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
james-nesbitt
commented
Nov 5, 2024
james-nesbitt
commented
- allow connection objects to have a sudofn injected
- if sudofn is set, then Connect won't try to detect it
kke
requested changes
Nov 5, 2024
james-nesbitt
force-pushed
the
PRODENG-2744-allow-sudofn-inject
branch
from
0d51bc6
to
e2eb795
Compare
kke
approved these changes
Nov 5, 2024
- allow connection objects to have a sudofn injected - if sudofn is set, then Connect won't try to detect it Signed-off-by: James Nesbitt <[email protected]>
james-nesbitt
force-pushed
the
PRODENG-2744-allow-sudofn-inject
branch
from
e2eb795
to
c604d0a
Compare
|
@kke I just want to do some testing on my implementation with this concept before you consider merging it. I will just turn this into a draft during that testing. |
james-nesbitt
added a commit
to Mirantis/mcc
that referenced
this pull request
Nov 8, 2024
- host flag allows explicit sudo assign, preventing rig discovery required rig k0sproject/rig#227 Signed-off-by: James Nesbitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.