Refactor cmd/rigtest into a real test suite in test/rig_test.go and fix found bugs #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kke
added
bug
kke
force-pushed
the
rigtest-to-test
branch
18 times, most recently
from
aee184a
to
48c8ba7
Compare
twz123
reviewed
Dec 20, 2023
kke
force-pushed
the
rigtest-to-test
branch
2 times, most recently
from
4145868
to
1a8d5d2
Compare
kke
changed the title
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cmd/rigtesttool was replaced with an actual test suite intest/rig_test.go. The improved tests uncovered a bunch of bugs that were fixed in this one as well.The details of what was fixed were lost while this got quite complex, which is again a sign that the library has become too complicated for its own good and need to be addressed in #92 or other PRs.