Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go 1.18 BuildInfo for version when installed using go install #508

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

kke
Copy link
Contributor

@kke kke commented Jun 26, 2023

Fixes #479

Go 1.18 added debug.ReadBuildInfo() which can be used to get the version number. This PR uses the wrapper at github.com/carlmjohnson/versioninfo to utilize that information.

This shouldn't have any effect on how the version is set when using make in the release pipeline.

@kke kke added the chore Housekeeping / typo / code quality improvements label Jun 26, 2023
@kke kke merged commit 04a76d8 into main Jun 26, 2023
@kke kke deleted the version-for-go-install branch June 26, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Housekeeping / typo / code quality improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minor: built k0sctl via 'go install', 'k0sctl version' reports 0.0.0
1 participant