Fix tee error when uploading k0s binaries #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twz123
approved these changes
Apr 4, 2022
| return true | ||
| for _, f := range h.Files { | ||
| if f.IsURL() { | ||
| log.Debugf("%s: marked for upgrade because there are URL source file uploads for the host", h) |
There was a problem hiding this comment.
There's even the possibility in getting the file size and modification date from an URL. A HEAD request and an inspection of the Content-Length and Last-Modified headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #357
Expands and reorders the three part host selection filter in
Upload Binariesphase. This may or may not fix the tee issue.Also changes the
needsUpgradefunction to return false if thehost.Filesorhost.K0sBinaryPathhave no file changes compared to remote.