Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ControlNode deletion to docs on how to remove a controller node #3809

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Add ControlNode deletion to docs on how to remove a controller node #3809

merged 1 commit into from
Dec 16, 2023

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Dec 11, 2023

Description

There's nothing that would handle automatic removal of those objects, currently. Documenting the manual deletion is the least we can do about this.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Add ControlNode deletion to docs on how to remove a controller node
086b243 
There's nothing that would handle automatic removal of those objects,
currently. Documenting the manual deletion is the least we can do about
this.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added the documentation Improvements or additions to documentation label Dec 11, 2023
@twz123 twz123 requested a review from a team as a code owner December 11, 2023 15:35
@twz123 twz123 requested review from kke and jnummelin December 11, 2023 15:35
@twz123 twz123 mentioned this pull request Dec 11, 2023
Closed
4 tasks
@twz123 twz123 added the backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch label Dec 11, 2023
@twz123 twz123 merged commit acb76fe into k0sproject:main Dec 16, 2023
7 checks passed
@twz123 twz123 deleted the docs-del-controlnode branch December 16, 2023 11:28
@k0s-bot
Copy link

k0s-bot commented Dec 16, 2023

Successfully created backport PR for release-1.28:

@k0s-bot k0s-bot mentioned this pull request Dec 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@kke kke kke approved these changes

Assignees
No one assigned
Labels
backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twz123 @k0s-bot @kke @jnummelin