Hide global flags added by embedded kubectl #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kke
force-pushed
the
hide-unused-args
branch
from
13ee46e
to
e06c8e4
Compare
mikhail-sakhnov
previously approved these changes
Dec 16, 2021
kke
force-pushed
the
hide-unused-args
branch
from
d3b8e75
to
b3b1d8d
Compare
mikhail-sakhnov
previously approved these changes
Dec 21, 2021
Signed-off-by: Kimmo Lehto <[email protected]>
kke
force-pushed
the
hide-unused-args
branch
from
b3b1d8d
to
d8cefa6
Compare
mikhail-sakhnov
approved these changes
Dec 28, 2021
ncopa
pushed a commit
that referenced
this pull request
Jan 10, 2022
Signed-off-by: Kimmo Lehto <[email protected]> (cherry picked from commit 814deb1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1273
Can't reopen #1274 for some reason so here it is again, slightly modified. Hides the
--versionand--log-flush-frequencyglobal flags that get added when importing the kubectl cmd package.Signed-off-by: Kimmo Lehto [email protected]