-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using "-" as filename to read config from stdin does not work #2917
Labels
Comments
kke
added a commit
that referenced
this issue
Mar 27, 2023
Fixes #2917 Reading a file to check that it is readable before actually reading it is not best practice. Just let it fail when reading it. Signed-off-by: Kimmo Lehto <[email protected]>
kke
added a commit
that referenced
this issue
Mar 27, 2023
Fixes #2917 Reading a file to check that it is readable before actually reading it is not best practice. Just let it fail when reading it. Signed-off-by: Kimmo Lehto <[email protected]>
kke
added a commit
that referenced
this issue
Mar 27, 2023
Fixes #2917 Reading a file to check that it is readable before actually reading it is not best practice. Just let it fail when reading it. Signed-off-by: Kimmo Lehto <[email protected]>
The issue is marked as stale since no activity has been recorded in 30 days |
The issue is marked as stale since no activity has been recorded in 30 days |
It's still broken, #3072 fixes it for at least |
The issue is marked as stale since no activity has been recorded in 30 days |
The issue is marked as stale since no activity has been recorded in 30 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Before creating an issue, make sure you've checked the following:
Platform
Version
All since at least #1409
Sysinfo
No response
What happened?
Reading the config from stdin is broken. The docs for the config flag claim
-
can be used to read the config from stdin.Steps to reproduce
Expected behavior
Either it should work or it shouldn't claim reading from stdin is supported.
Actual behavior
It tries to open a file called
-
.Screenshots and logs
No response
Additional context
The
config.GetCmdOpts()
should maybe return(CLIOptions, error)
instead of justCLIOptions
. It now useslog.Fatalf
to bail out, which is a bit problematic for command tests.Slightly related to #2791
The text was updated successfully, but these errors were encountered: