Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES6 Update #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ES6 Update #11

wants to merge 1 commit into from

Conversation

mskr
Copy link

@mskr mskr commented Jun 6, 2021

  • async execute functions
  • async undo functions
  • ES6 module

@mskr
ES6 Update
6e5037a 
- async execute functions
- async undo functions
- ES6 module
@mskr
Copy link
Author

mskr commented Jun 6, 2021

@jzaefferer Can review this?

@mskr mskr mentioned this pull request Jun 6, 2021
Open
@jzaefferer
Copy link
Owner

The diff looks fine to me. Surely breaking changes, but that's expected.

Did you check if the demos are still working with these changes? Since that's the only documentation there is, it would be helpful to keep them alive.

@mskr
Copy link
Author

mskr commented Jun 6, 2021

Great. However I did not look at the examples yet, but agree, it would be very helpful to have them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzaefferer jzaefferer jzaefferer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mskr @jzaefferer