Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to DeferredConfirmations and implement Batch Publishing #36 #59

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

escb005
Copy link
Contributor

@escb005 escb005 commented Apr 24, 2024

No description provided.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 54.93827% with 73 lines in your changes missing coverage. Please review.

Project coverage is 57.88%. Comparing base (79bd2e5) to head (7c73f68).
Report is 88 commits behind head on main.

Files with missing lines Patch % Lines
pool/confirmation.go 36.50% 36 Missing and 4 partials ⚠️
pool/publisher.go 50.00% 15 Missing and 4 partials ⚠️
amqpx.go 0.00% 8 Missing ⚠️
pool/session.go 88.67% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   58.72%   57.88%   -0.85%     
==========================================
  Files          27       34       +7     
  Lines        3748     3464     -284     
==========================================
- Hits         2201     2005     -196     
+ Misses       1375     1293      -82     
+ Partials      172      166       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants