Add an option to verify the signature on decode #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a good idea. I wonder if it would be a good idea for the 'allowed algorithm' to be an array? In many cases, I would expect multiple algorithms to be acceptable rather than requiring a single exact match. |
|
@javawizard Thanks for the PR. I will check and merge it tonight. @danleyden IMO checking only one algo is the better solution. Checking against different algorithms is a feature that depends on each individual project. We should simply focus on the stability of the lib and keep things simple. It may be a feature for version 2.x to handle multiple allowed algos that the ruby-jwt will check against. |
excpt
added a commit
that referenced
this pull request
Apr 10, 2015
Make syntax 1.8.7 and 1.9.x compatible again
|
Hello, when it will be pushed to Rubygems? We need to specify the algorithm to avoid vulnerabilities (#76) |
aarongray
added a commit
to aarongray/ruby-jwt
that referenced
this pull request
Oct 6, 2015
This parameter is necessary to prevent attackers from bypassing the algorithm verification step. See: https://auth0.com/blog/2015/03/31/critical-vulnerabilities-in-json-web-token-libraries/ jwt#76 jwt#71 jwt#107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.