Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using the term invalidate to not assume the app always has a cache #501

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Stop using the term invalidate to not assume the app always has a cache #501

merged 1 commit into from
Jul 13, 2022

Conversation

anakinj
Copy link
Member

@anakinj anakinj commented Jul 11, 2022 •
edited
Loading

This is addressing the concerns of #499 by:

  • "Rename" the invalidate options of the jwk proc to kid_not_found
  • Improving the readme when it comes to the JWK key loader proc

@anakinj
Copy link
Member Author

anakinj commented Jul 11, 2022

@liamdawson Was thinking something like this.

@anakinj anakinj force-pushed the improve-jwk-loader branch 2 times, most recently from 4061fee to 9e5f96a Compare July 11, 2022 20:24
excpt
excpt approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@excpt excpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 💯

@excpt excpt added this to the 2.5.0 milestone Jul 11, 2022
@anakinj anakinj merged commit b79e4b5 into jwt:master Jul 13, 2022
@liamdawson liamdawson mentioned this pull request Jul 15, 2022
Closed
@liamdawson liamdawson mentioned this pull request Jul 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@excpt excpt excpt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anakinj @excpt