Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass kid param through JWT::JWK.create_from #445

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Pass kid param through JWT::JWK.create_from #445

merged 1 commit into from
Sep 30, 2021

Conversation

shaun-guth-allscripts
Copy link

The underlying keypair classes already support an optional second parameter for the key id; however, the JWT::JWK interface didn't provide any mechanism for setting them via the constructor.

@sourcelevel-bot
Copy link

Hello, @shaun-guth-allscripts! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@anakinj
Copy link
Member

anakinj commented Sep 29, 2021

Looks great. Could you be so kind and fix the RuboCop issue mentioned here: https://github.com/jwt/ruby-jwt/pull/445/checks?check_run_id=3740502864

@sourcelevel-bot
Copy link

SourceLevel has finished reviewing this Pull Request and has found:

  • 2 possible new issues (including those that may have been commented here).

But beware that this branch is 1 commit behind the jwt:master branch, and a review of an up to date branch would produce more accurate results.

See more details about this review.

@shaun-guth-allscripts
Copy link
Author

Looks great. Could you be so kind and fix the RuboCop issue mentioned here: https://github.com/jwt/ruby-jwt/pull/445/checks?check_run_id=3740502864

This should be fixed now - thanks for looking into it!

@anakinj anakinj merged commit a4270e8 into jwt:master Sep 30, 2021
@shaun-guth-allscripts shaun-guth-allscripts deleted the feature/jwk-specify-kid branch September 30, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants