Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rspec 3 breaks passing tests #44

Merged
merged 3 commits into from
Sep 9, 2014
Merged

rspec 3 breaks passing tests #44

merged 3 commits into from
Sep 9, 2014

Conversation

zshannon
Copy link

@zshannon zshannon commented Sep 9, 2014

To reproduce, install rspec 3.0+ and run rake test. It will produce 3 failures where be_true and be_false are used when rspec 3 expects be_truthy and be_falsey.

We can:

  1. lock the gem version to 2+ (as I have in this PR), or,
  2. update the tests to support version 3+, which I'm happy to do on this PR if that's the preferred resolution.

@progrium
Copy link
Contributor

progrium commented Sep 9, 2014

Supporting version 3 to keep it fresh would be great!

@zshannon
Copy link
Author

zshannon commented Sep 9, 2014

@progrium all set.

progrium added a commit that referenced this pull request Sep 9, 2014
@progrium
Merge pull request #44 from zshannon/rspec-3
34b3f39 
rspec 3 breaks passing tests
@progrium progrium merged commit 34b3f39 into jwt:master Sep 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zshannon @progrium