Support JWKs for pre 2.3 rubies #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakinj
force-pushed
the
fix-older-rubies
branch
2 times, most recently
from
87c68de
to
699dfaa
Compare
|
2x Truffleruby builds failed because of something random. The flaky tests runs are also tagged as |
anakinj
force-pushed
the
fix-older-rubies
branch
2 times, most recently
from
35f58e2
to
4206fe7
Compare
anakinj
force-pushed
the
fix-older-rubies
branch
11 times, most recently
from
fd42662
to
dc98e1d
Compare
anakinj
force-pushed
the
fix-older-rubies
branch
from
dc98e1d
to
6c699f1
Compare
|
Merged this to have working CI for 2.1 and 2.2 while working on some refactorings on the JWK parts of the gem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue in #361. Even if the Rubies are EOL and stone-age we should probably still support them while the gemspec claims to support
>= 2.1Part of the problem is that the CI has not been executed for pre 2.3 versions in a while, was thinking we could maybe add the older rubies to the test matrix in #381 before we remove the support completely in the next major version of this gem.