-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verifies algorithm before evaluating keyfinder #346
Conversation
Hello, @jb08! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
CI failing unrelated to PR, no?
|
cc: @laurawyse @pjo336 |
This looks good to me also. I made a change to the key loader and I'd also like to see this rolled into the next release with both our changes. See #348 |
thanks @bdewater for the approval. |
issue 343 PR (coordinated with @zinosama)