Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RSA.import for all Ruby versions. #333

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Support RSA.import for all Ruby versions. #333

merged 1 commit into from
Sep 18, 2019

Conversation

rabajaj0509
Copy link
Contributor

For Ruby versions < 2.4.0:

2.3.5 :006 > OpenSSL::PKey::RSA.new.respond_to?(:set_key)
 => false

This patch makes sure that RSA.import method is supported for all versions of Ruby.

@sourcelevel-bot
Copy link

Hello, @rahulbajaj0509! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@sourcelevel-bot
Copy link

SourceLevel has finished reviewing this Pull Request and has found:

  • 1 possible new issue (including those that may have been commented here).

You can see more details about this review at https://app.sourcelevel.io/github/jwt/ruby-jwt/pulls/333.

@excpt excpt self-requested a review September 18, 2019 21:24
@excpt excpt merged commit f4c7f15 into jwt:master Sep 18, 2019
@excpt
Copy link
Member

excpt commented Sep 18, 2019

Fixes #332.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants