Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed leeway from verify_iat #257

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Removed leeway from verify_iat #257

merged 2 commits into from
Mar 22, 2018

Conversation

ab320012
Copy link
Contributor

@ab320012 ab320012 commented Mar 22, 2018 •
edited by excpt
Loading

Fixes #247.

@excpt excpt self-requested a review March 22, 2018 09:15
excpt
excpt requested changes Mar 22, 2018
View reviewed changes
Copy link
Member

@excpt excpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test should be added to ensure that the leeway is not applied to the iat claim when the token is verified.

spec/jwt/verify_spec.rb
@@ -87,14 +87,6 @@ module JWT
Verify.verify_iat(payload, options)
end

it 'must allow configured leeway' do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to invert one of these tests to ensure that the leeway is ignored.

@excpt
Copy link
Member

excpt commented Mar 22, 2018

@ab320012 Thank you for the PR! I added my review. :) Let me know if you have the time to improve that or if any help is needed.

@excpt excpt changed the title removed leeway from verify_iat and tests issue #247 Removed leeway from verify_iat Mar 22, 2018
excpt
excpt approved these changes Mar 22, 2018
View reviewed changes
Copy link
Member

@excpt excpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@excpt excpt added this to the Version 2.2.0 milestone Mar 22, 2018
@excpt excpt merged commit dba5c9b into jwt:master Mar 22, 2018
@Jack12816
Copy link

Thanks, guys!

@anakinj anakinj mentioned this pull request Jun 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@excpt excpt excpt approved these changes

Assignees
No one assigned
Labels
bug enhancement security
Projects
None yet
Milestone
Version 2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ab320012 @excpt @Jack12816