verify takes 2 params, second being payload closes: #207 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
lib/jwt/verify.rb
Outdated
| @@ -63,7 +63,11 @@ def verify_jti | |||
| jti = @payload['jti'] | |||
|
|
|||
| if options_verify_jti.respond_to?(:call) | |||
| raise(JWT::InvalidJtiError, 'Invalid jti') unless options_verify_jti.call(jti) | |||
| raise(JWT::InvalidJtiError, 'Invalid jti') unless ( | |||
There was a problem hiding this comment.
Don't use parentheses around the condition of an unless.
lib/jwt/verify.rb
Outdated
| @@ -63,7 +63,11 @@ def verify_jti | |||
| jti = @payload['jti'] | |||
|
|
|||
| if options_verify_jti.respond_to?(:call) | |||
| raise(JWT::InvalidJtiError, 'Invalid jti') unless options_verify_jti.call(jti) | |||
| raise(JWT::InvalidJtiError, 'Invalid jti') unless ( | |||
| options_verify_jti.arity == 2 ? | |||
There was a problem hiding this comment.
Avoid multi-line ternary operators, use if or unless instead.
ab320012
changed the title
ab320012
force-pushed
the
add-payload-to-verify-jti
branch
from
70ee808
to
bb31372
Compare
ab320012
force-pushed
the
add-payload-to-verify-jti
branch
from
bb31372
to
e348ee3
Compare
excpt
approved these changes
Oct 5, 2017
|
@ab320012 Thanks for the PR! |
|
@excpt Thanks Tim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional payload to verify_jti + passing tests for payload and arguements #207