Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with signature verification in JRuby #10

Merged
merged 7 commits into from
Jul 20, 2012

Conversation

sporkmonger
Copy link
Contributor

There's a weird discrepancy between how signatures are verified in JRuby and in all other Rubies. I've worked around this issue by adding a begin..rescue block to catch the extra exception that JRuby throws in some scenarios.

Also updates the version number for release.

Any chance this could get pulled and released soonish? This error is wreaking havoc on our continuous build. :-/

@sporkmonger
Copy link
Contributor Author

Tests are all passing.

@sporkmonger
Copy link
Contributor Author

Looked like there was a conflict, so I resolved it and fixed the tests that started failing from the other merge.

@progrium
Copy link
Contributor

This is great, thanks. You beat me to it all.

progrium added a commit that referenced this pull request Jul 20, 2012
Fix issue with signature verification in JRuby
@progrium progrium merged commit 6915be7 into jwt:master Jul 20, 2012
@sporkmonger
Copy link
Contributor Author

BTW, since I added a .travis.yml, could you set up the Travis web hook for the repo? You may also want to add a notification block like this:

notifications:
  email:
    recipients:
      - [email protected]
    on_success: change
    on_failure: change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants