Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix either README or source code #78

Closed
AlexParamonov opened this issue May 11, 2015 · 2 comments
Closed

Fix either README or source code #78

AlexParamonov opened this issue May 11, 2015 · 2 comments
Labels
bug documentation enhancement

Comments

@AlexParamonov
Copy link

I found that README has incorrect (not yet implemented) examples.
I do use the iss check in the app and implemented it using my wrapper class.

After the 1.5 released, I removed the wrapper and tested the jwt gem. It appears that it requires special "setup" before:
5c09aad#commitcomment-11125584
excpt added a commit that referenced this issue May 11, 2015
@excpt
Update README (related to #78)
f2fe2ac 
Fix typos and add missing information that is needed in order to have
the code working correct.
@excpt
Copy link
Member

excpt commented May 11, 2015

@AlexParamonov I updated the docs. I ran all the code snippets. Will you review the changes?

@AlexParamonov
Copy link
Author

@excpt looks good. We can close the issue now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug documentation enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@excpt @AlexParamonov