Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the encondig code #121

Closed
excpt opened this issue Jan 12, 2016 · 2 comments
Closed

Refactor the encondig code #121

excpt opened this issue Jan 12, 2016 · 2 comments
Assignees
@excpt
Labels
enhancement refactoring
Milestone
Version 2.0.0

Comments

@excpt
Copy link
Member

excpt commented Jan 12, 2016

Refactor the encoding code. Extract it from the jwt.rb monolith into a separate jwt/encode.rb file.
@excpt excpt self-assigned this Jan 12, 2016
@excpt excpt added this to the Version 1.5.3 milestone Jan 12, 2016
@excpt excpt modified the milestones: Version 1.5.4, Version 1.5.3 Feb 24, 2016
@excpt excpt added 2.0 and removed 2.0 labels Mar 23, 2016
@excpt excpt modified the milestones: Version 1.6.0, Version 1.5.4 Mar 27, 2016
@ogonki-vetochki ogonki-vetochki mentioned this issue Dec 6, 2016
Merged
excpt added a commit that referenced this issue Dec 7, 2016
@excpt
Merge pull request #182 from xamenrax/refactor_encode
efa3e96 
Basic encode module refactoring #121
@ogonki-vetochki
Copy link
Contributor

Hi! Could we close this already? Or maybe you have some additions/commentaries?

@excpt
Copy link
Member Author

excpt commented Dec 22, 2016

Forgot to click the button. Sorry. :)

@excpt excpt closed this as completed Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@excpt excpt

Labels
enhancement refactoring
Projects
None yet
Milestone
Version 2.0.0
Development

No branches or pull requests
2 participants
@excpt @ogonki-vetochki