Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AD -775][JW8-11235] JWPlayer Targeting module #3

Merged
merged 26 commits into from
Jul 14, 2020
Merged

[AD -775][JW8-11235] JWPlayer Targeting module #3

merged 26 commits into from
Jul 14, 2020

Commits on Jul 6, 2020

  1. ssets up targeting module

    karimJWP authored and karimJWP committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    38bf558 View commit details
    Browse the repository at this point in the history

  2. implements getTargeting

    karimJWP authored and karimJWP committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    432122a View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. implements getPlayer

    karimJWP authored and karimJWP committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    599a243 View commit details
    Browse the repository at this point in the history

  2. blocks bids until all targeting requests complete

    karimJWP authored and karimJWP committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    410f963 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. makes getTarget more resilient

    karimJWP authored and karimJWP committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    0003a3d View commit details
    Browse the repository at this point in the history

  2. enables mdule hook

    karimJWP authored and karimJWP committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    18f83cc View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. replaces triple dot notation

    karimJWP authored and karimJWP committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    7a76ea6 View commit details
    Browse the repository at this point in the history

  2. Revert "replaces triple dot notation" 

    This reverts commit 7a76ea6.
    karimJWP authored and karimJWP committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    130aa2a View commit details
    Browse the repository at this point in the history

  3. Revert "Revert "replaces triple dot notation"" 

    This reverts commit 130aa2a.
    karimJWP authored and karimJWP committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    01f2f18 View commit details
    Browse the repository at this point in the history

  4. checks current item only if mediaid is missing

    karimJWP authored and karimJWP committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    a54c567 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. adds unit tests

    karimJWP authored and karimJWP committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    0293d2d View commit details
    Browse the repository at this point in the history

  2. completes test cases

    karimJWP authored and karimJWP committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    1789d8d View commit details
    Browse the repository at this point in the history

  3. stores segments for current item

    karimJWP authored and karimJWP committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    79b7b84 View commit details
    Browse the repository at this point in the history

  4. renames jwp targeting

    karimJWP authored and karimJWP committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    296a6cb View commit details
    Browse the repository at this point in the history

  5. refactors fetch tests

    karimJWP authored and karimJWP committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    eb132fa View commit details
    Browse the repository at this point in the history

  6. refactors get targeting tests

    karimJWP authored and karimJWP committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    ddf873f View commit details
    Browse the repository at this point in the history

  7. refactors blocking tests

    karimJWP authored and karimJWP committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    40fd468 View commit details
    Browse the repository at this point in the history

  8. renames module

    karimJWP authored and karimJWP committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    7fcfcd1 View commit details
    Browse the repository at this point in the history

  9. cleans changes made to app nexus

    karimJWP authored and karimJWP committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    49e983d View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. removes setup and player utilities

    karimJWP authored and karimJWP committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    5cada07 View commit details
    Browse the repository at this point in the history

  2. renames onFetchCompletion

    karimJWP authored and karimJWP committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    2ee0d2f View commit details
    Browse the repository at this point in the history

  3. renames onFetchCOmpletion in unti tests

    karimJWP authored and karimJWP committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    c1ef816 View commit details
    Browse the repository at this point in the history

  4. throws instead of early return

    karimJWP authored and karimJWP committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    87796fd View commit details
    Browse the repository at this point in the history

  5. reduces timeout and introduces override

    karimJWP authored and karimJWP committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    dde5ff0 View commit details
    Browse the repository at this point in the history

  6. targeting timeout supersedes

    karimJWP authored and karimJWP committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    61cf182 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. renames feed fetch timeout

    karimJWP authored and karimJWP committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    5ab3c78 View commit details
    Browse the repository at this point in the history