Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(channel-msg-reject): send reject function to underlying channel #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thuydx55
Copy link

No description provided.

@thuydx55 thuydx55 changed the title feat(channel-msg-reject): send function to underlying channel feat(channel-msg-reject): send reject function to underlying channel Dec 15, 2021
@thuydx55
Copy link
Author

@jwalton please take a look into this. Thanks

@luddd3
Copy link
Collaborator

luddd3 commented Dec 28, 2021

Can you use #nack(message, false, requeue) instead? reject is a function in amqplib to maintain backwards compatibility with very old versions of RabbitMq (< v2.3.0).

I think it makes more sense for this lib to only have one method to nack messages.

https://amqp-node.github.io/amqplib/channel_api.html#channel_reject

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants