fix: Fix handling of resending messages during a disconnect. #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unit tests for this had a fatal flaw - they assumed that if the connection dropped, we'd get nothing back for any in-flight messages. This isn't true, though - we'd actually get back an error from amqplib when the underlying connection fails. This fixes the tests to reflect this. If we rely on amqplib to reject such messages, then moving all messages from _unconfirmedMessages to _messages on a reconnect now becomes superfluous. I also reworked `_publishQueuedMessages()` to be more synchronous. As it stood, I had to add a lot of pointless delays in my tests to make sure that the `then` after publishing a message had time to run. fix #152
|
@luddd3 could I bother you for a quick review of this please? :) |
fitzhavey
approved these changes
Aug 26, 2021
|
🎉 This PR is included in version 3.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I also think it looks fine. I'll do some testing with drain, etc. tomorrow. I'm currently working on consumer reconnects. |
|
Worked fine in my tests at least =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests for this had a fatal flaw - they assumed that if the
connection dropped, we'd get nothing back for any in-flight messages.
This isn't true, though - we'd actually get back an error from amqplib
when the underlying connection fails. This fixes the tests to reflect
this. If we rely on amqplib to reject such messages, then moving all
messages from _unconfirmedMessages to _messages on a
reconnect now becomes superfluous.
I also reworked
_publishQueuedMessages()to be more synchronous.As it stood, I had to add a lot of pointless delays in my tests to make
sure that the
thenafter publishing a message had time to run.fix #152