Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for per URL connection options #29

Closed
skaegi opened this issue May 3, 2018 · 4 comments
Closed

Support for per URL connection options #29

skaegi opened this issue May 3, 2018 · 4 comments

Comments

@skaegi
Copy link
Contributor

skaegi commented May 3, 2018

Some of the connectionOptions we use are per URL (for example "servername" which boils down to TLSSocket.servername and used as part of the TLS Server Name Indication). Could connect be altered to accept an array of {url:... , options:...} or something along those lines.
@jwalton
Copy link
Owner

jwalton commented May 5, 2018

That definitely sounds like it could be done - make it so urls is either a list of strings, or a list of {url, options} or a mixed list? I'd welcome a PR. I just refactored this entire codebase from coffeescript to javascript, so it should be a little easier to contribute to now. :)

@skaegi
Copy link
Contributor Author

skaegi commented May 10, 2018

Thanks @jwalton -- sorry for the delay. I think I can look at doing this when I get a moment...

@skaegi
Copy link
Contributor Author

skaegi commented Jun 4, 2018

@jwalton Here's the general idea -- #34

@jwalton jwalton closed this as completed Jun 7, 2018
jwalton pushed a commit that referenced this issue Aug 9, 2018
feat: Support for per URL connection options
4c7fe7c 
Empty commit for the benefit of semantic-release.

fix #29 #34
jwalton pushed a commit that referenced this issue Aug 9, 2018
feat: Support for per URL connection options
ec2d484 
Empty commit for the benefit of semantic-release.

fix #29 #34 #44
benbriadeploy pushed a commit that referenced this issue Aug 9, 2018
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
ae89b82 
# [2.1.0](v2.0.0...v2.1.0) (2018-08-09)

### Features

* Support for per URL connection options ([ec2d484](ec2d484)), closes [#29](#29) [#34](#34) [#44](#44)
@benbriadeploy
Copy link

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skaegi @jwalton @benbriadeploy