Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ConstructionBase #91

Merged
merged 2 commits into from
Oct 9, 2019
Merged

use ConstructionBase #91

merged 2 commits into from
Oct 9, 2019

Conversation

jw3126
Copy link
Owner

@jw3126 jw3126 commented Oct 1, 2019

No description provided.

@jw3126 jw3126 mentioned this pull request Oct 1, 2019
Open
12 tasks
tkf
tkf reviewed Oct 1, 2019
View reviewed changes
Project.toml Outdated Show resolved Hide resolved
tkf
tkf reviewed Oct 2, 2019
View reviewed changes
Project.toml Outdated Show resolved Hide resolved
tkf
tkf reviewed Oct 2, 2019
View reviewed changes
test/test_quicktypes.jl Outdated Show resolved Hide resolved
@colinxs colinxs mentioned this pull request Oct 8, 2019
Closed
@tkf tkf mentioned this pull request Oct 8, 2019
Closed
@tkf tkf closed this Oct 8, 2019
@tkf tkf reopened this Oct 8, 2019
@jw3126 jw3126 closed this Oct 9, 2019
@jw3126 jw3126 reopened this Oct 9, 2019
@jw3126
Copy link
Owner Author

jw3126 commented Oct 9, 2019

@tkf Do you know why CI fails? Locally I can ]add ConstructionBase just fine. Does Travis some magic caching?

@tkf
Copy link
Collaborator

tkf commented Oct 9, 2019

I think it's working https://travis-ci.org/jw3126/Setfield.jl/builds/595455069 (click continuous-integration/travis-ci/pr above the merge button)? If you are looking at continuous-integration/travis-ci/push, that's the CI for this branch as-is built when you pushed, different from the one you can restart via close-then-open.

@jw3126
Copy link
Owner Author

jw3126 commented Oct 9, 2019

Ah I see, thanks for explaining.

@jw3126 jw3126 merged commit 5329d33 into master Oct 9, 2019
@tkf
Copy link
Collaborator

tkf commented Oct 9, 2019

image

You can also click this right-top Restart build button.

@jw3126
Copy link
Owner Author

jw3126 commented Oct 9, 2019

@tkf I would like to tag a release, any objections?

@tkf
Copy link
Collaborator

tkf commented Oct 9, 2019

I think it's good to go. FYI, testing Kaleido with Setfield 0.5 worked: tkf/Kaleido.jl#8

@jw3126
Copy link
Owner Author

jw3126 commented Oct 9, 2019

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Pull request comments will not trigger Registrator as it is disabled. Please trying using a commit or issue comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkf tkf tkf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jw3126 @tkf @JuliaRegistrator