Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aaron #4

Merged
merged 20 commits into from
Dec 15, 2023
Merged

Aaron #4

merged 20 commits into from
Dec 15, 2023

Conversation

AaronCooke2718
Copy link
Collaborator

Fixed misspellings
Added the missing fiscal assistance programs

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (b617f20) 78.4% compared to head (62e154f) 87.0%.

Files Patch % Lines
covid19_drdfm/scm.py 0.0% 12 Missing ⚠️
covid19_drdfm/dfm.py 82.3% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main      #4     +/-   ##
=======================================
+ Coverage   78.4%   87.0%   +8.5%     
=======================================
  Files          3       5      +2     
  Lines        158     162      +4     
  Branches      30      29      -1     
=======================================
+ Hits         124     141     +17     
+ Misses        33      18     -15     
- Partials       1       3      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jvivian
Copy link
Owner

jvivian commented Dec 7, 2023

@AaronCooke2718

All tests are passing. The quality test is failing when it didn't used to due to an inability to find pre-commit in the test env,, but isn't a blocker for merging.

@jvivian
Copy link
Owner

jvivian commented Dec 8, 2023

@AaronCooke2718 - This PR is growing unwieldy (no longer single-issue), so I am going to merge it into master tonight or tomorrow after another review. Additional development for a given issue can then take place on an upstream branch.

@jvivian jvivian merged commit 4365791 into main Dec 15, 2023
3 of 7 checks passed
@jvivian jvivian deleted the Aaron branch December 15, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants